Linked Issues

• Closes https://github.com/sourcegraph/sourcegraph/issues/35027

Motivation and Context:

• To improve the UX by displaying the invalid token error message on the UI to the users while adding a code host connection

Existing Issue Root Cause:

• After the submit button is clicked while adding a code host connection, the existing code navigates to the /site-admin/external-services/${data.addExternalService.id} page (the page which displays information of the newly added code host connection) before the error message could even be displayed on the current page

Changes Made:

• Modified the onSubmit function (the one which is called when the submit button is clicked on the code host connection addition page) to only navigate to the /site-admin/external-services/${data.addExternalService.id} page (newly added code host information page) only if no error/warning is returned from the gRPC call which validates the token of the code host added

Type of change:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactoring (altering code without changing its external behaviour)
• Documentation change
• Other

Checklist:

• Development completed
• Comments added to code (wherever necessary)
• Documentation updated (if applicable)
• Tested changes locally

Follow-up tasks (if any):

• None

Test Plan

• Had setup the codebase locally and tested the entire flow locally end-to-end
• Screen recording which shows the invalid token error message on the UI in the code host connection addition flow:

Additional Comments

• Please let me know if any further changes are required elsewhere