This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Make username key configurable for SAML auth providers#60603
Merged
Conversation
eseliger
approved these changes
Feb 19, 2024
eseliger
left a comment
Member
There was a problem hiding this comment.
From that issue, it sounds like that the two providers use different methods to derive the key to uniquely identify a user - do I get that right?
I think I agree with that just changing this will be dangerous, as some customers might rely on this.
Can we make sure to reach out to Chris who filed the ticket to inform the customer about this change and that they should give it a try?
Contributor
|
I think that this change will provide a satisfactory workaround. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59877
Docs change: sourcegraph/docs#105
Instead of changing the ordering of how the SAML auth provider selects a username (which could cause backwards compatibility issues for existing setups), I decided to add a
usernameAttributeNamesfield to the SAML auth provider config. This way an admin can specify their own preferred set of SAML username keys and configure it based on their preference.Test plan
Existing tests still passing, new unit test added.