This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Add exclude repo functionality for azure devops and gerrit#60509
Merged
Conversation
eseliger
approved these changes
Feb 14, 2024
eseliger
left a comment
Member
There was a problem hiding this comment.
Nice! Were you able to verify this behavior with an actual devops connection?
Side-q while we're here: Are there any other code hosts missing here that otherwise support exclusion?
Also: Maybe a changelog entry?
Contributor
Author
|
@eseliger Yep I tested this locally with an actual DevOps connection :) I'll have a look at other code hosts |
eseliger
approved these changes
Feb 15, 2024
| expectedConfig: `{"accessKeyID":"accessKeyID","exclude":[{"name":"test"}],"gitCredentials":{"password":"","username":""},"region":"","secretAccessKey":""}`, | ||
| }, | ||
| { | ||
| name: "second attempt of excluding same repo is ignored for Azure DevOps schema", |
Contributor
Author
There was a problem hiding this comment.
I don't think so? 🤔 it's the name for all of these tests. They try to exclude the repo twice and confirm it's only excluded once
…/60346-azure-devops-exclude-repo-button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60346
Adds the missing cases for Azure DevOps and Gerrit so that repos can be excluded through the UI
Test plan
Add unit test and verify manually