Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

[Backport 5.3] Fix panics in streaming completions handler#60476

Merged
keegancsmith merged 1 commit into
5.3from
backport-60474-to-5.3
Feb 13, 2024
Merged

[Backport 5.3] Fix panics in streaming completions handler#60476
keegancsmith merged 1 commit into
5.3from
backport-60474-to-5.3

Conversation

@sourcegraph-release-bot

Copy link
Copy Markdown
Collaborator

Closes #60439

2 issues:

  • if no attribution search is triggered it can wait forever
  • if the attribution search returns a result while we stream other stuff, we might concurrently flush, causing panics (the panic message is not 100% the one from the ticket, but very close, and we were able to repro that, and not anymore after the fix)

Test plan

* Fix panics in streaming completions handler

* FMT

(cherry picked from commit 52dffbb)
@keegancsmith keegancsmith enabled auto-merge (squash) February 13, 2024 13:35
@keegancsmith keegancsmith added the backport/bugfix Standard patches to fix bugs label Feb 13, 2024
@keegancsmith keegancsmith merged commit 8d9b1ad into 5.3 Feb 13, 2024
@keegancsmith keegancsmith deleted the backport-60474-to-5.3 branch February 13, 2024 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants