This repository was archived by the owner on Sep 30, 2024. It is now read-only.
batches: change criteria for deleting GitHub apps from the database#60460
Merged
Conversation
BolajiOlajide
commented
Feb 13, 2024
camdencheek
approved these changes
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54066
In the past, when we get an error fetching a GitHub app, we assume the app has been deleted and delete all it's installations from the database. This caused issues for one of our customers.
Test plan
Manual testing.
I added a GitHub app for Commit Signing, manually triggered the worker to ensure it refreshes it's installations. Then I faked an error in the code, to see if the installations got deleted when a refresh occurred (they didn't). They only got deleted when the client returns a 404.