This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Make perforce email matching case insensitive#60252
Merged
Merged
Conversation
eseliger
reviewed
Feb 7, 2024
eseliger
left a comment
Member
There was a problem hiding this comment.
Does that also cover the definitions in the p4 protects file getting matched against a users emails?
Co-authored-by: Erik Seliger <erikseliger@me.com>
Contributor
Author
|
@eseliger yeah the protects file uses a username if I'm not mistaken. The email is to set up the external account |
eseliger
approved these changes
Feb 7, 2024
eseliger
left a comment
Member
There was a problem hiding this comment.
gotcha, alright! (I know very little about how these things link up, but I trust you here and code and test LGTM) :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #58757
Makes perforce email matching case insensitive.
Test plan
Adjust and add unit test.