This repository was archived by the owner on Sep 30, 2024. It is now read-only.
batches: allow refreshing commit signing apps installation#60125
Merged
Conversation
5a353f3 to
ddd6b31
Compare
camdencheek
reviewed
Feb 14, 2024
camdencheek
reviewed
Feb 14, 2024
vovakulikov
approved these changes
Feb 14, 2024
vovakulikov
left a comment
Contributor
There was a problem hiding this comment.
FE review is ok, I see that only BatchChanges codebases adopted spring animations
camdencheek
approved these changes
Feb 14, 2024
e626ee4 to
92decd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives site admins the ability to refresh a commit signing app, instead of waiting for the periodic worker (which runs every 24 hours) to kick of the installation sync.
Test plan
Add a GitHub app on Sourcegraph for Commit Signing.
There should be a
Refreshbutton to refresh installations on the app.If the app is installed on any new org or account, the installations will be added to the database after the
Refreshoperation is done.