This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search: Disable 'jump to suggestion' behavior in secondary query inputs#59941
Merged
Conversation
vovakulikov
approved these changes
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been an issue for a while and has recently been reported again internally (Slack).
The "old" search input is still used in places other than the search and repository pages (i.e. everywhere that's not the main search input). These places are solely used for entering a query, not for navigating around, and so "jump to suggestion" for repositories and files should be disabled.
Test plan
Selecting a repository by pressing Enter in the search context query input updates the input instead of navigating to the repo page.