This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Add Exclude field to gerrit code host connections#59739
Merged
Conversation
…/gerrit-exclude-repositories
eseliger
reviewed
Jan 22, 2024
Comment on lines
+41
to
+48
| "exclude": { | ||
| "description": "An array of project strings specifying which Gerrit projects to exclude from mirroring on Sourcegraph. If empty, no projects will be excluded. Useful when using an empty 'projects' field. Exclusion takes precedence over inclusion.", | ||
| "type": "array", | ||
| "items": { "type": "string" }, | ||
| "examples": [ | ||
| ["name", "owner/name"], | ||
| ["docs", "kubernetes/kubernetes"] | ||
| ] |
Member
There was a problem hiding this comment.
Both GitHub and GitLab configs use objects here, to also allow excluding repos by other properties, like size, pattern, empty repos, external id, archived status etc.
We won't need that now, but will we ever want that, we might regret that we didn't make these objects now, do you think that'd be a huge hassle to add?
So proposed schema would instead be
"exclude": [{"name": "src-cli"}]
Contributor
Author
There was a problem hiding this comment.
Yeah I think this is a good idea even if only for consistency
eseliger
approved these changes
Jan 23, 2024
…/gerrit-exclude-repositories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
excludefield to Gerrit code host connections that acts as the inverse of theprojectsfield. Any repos in this list will never ever be added by this code host connection.Docs update: sourcegraph/docs#53
Test plan
Added unit tests