Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

re-land Cody RBAC change#59657

Merged
emidoots merged 6 commits into
mainfrom
sg/reland-rbac
Jan 17, 2024
Merged

re-land Cody RBAC change#59657
emidoots merged 6 commits into
mainfrom
sg/reland-rbac

Conversation

@emidoots

Copy link
Copy Markdown
Member

Brings back #59540

  • Revert the revert (bring back the change)
  • Fix the failing test case which was identified in main post-merge.

Test plan

Existing tests + prior testing.

Stephen Gutekanst added 2 commits January 16, 2024 15:51
@emidoots emidoots requested a review from burmudar January 17, 2024 08:06
@cla-bot cla-bot Bot added the cla-signed label Jan 17, 2024

@burmudar burmudar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏼

@emidoots emidoots marked this pull request as ready for review January 17, 2024 19:24
@emidoots emidoots enabled auto-merge (squash) January 17, 2024 19:24
Stephen Gutekanst added 2 commits January 17, 2024 13:31
Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
@emidoots emidoots merged commit 3511605 into main Jan 17, 2024
@emidoots emidoots deleted the sg/reland-rbac branch January 17, 2024 20:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants