This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Disables embeddings for all instances that are not dotcom#59493
Merged
Conversation
7da2a6c to
1c9164c
Compare
84845dd to
deec761
Compare
added 8 commits
January 23, 2024 11:50
9675338 to
7d288d8
Compare
eseliger
approved these changes
Jan 23, 2024
eseliger
left a comment
Member
There was a problem hiding this comment.
nice! it's gonna be great as well to be able to remove embeddings rate limiting from cody gateway, plus the management features in licensing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overrides the embeddings config to default embeddings to disabled unless the site is running in dotcom mode. This is a first minimal step to removing embeddings, dotcom is still dependent on the embeddings config to supply PLG rate limits for local generated embeddings and the current extension versions still use remote embeddings from dotcom as an additional context source.
When embeddings are no longer need for dotcom the code related to embeddings can be removed.
closes https://github.com/sourcegraph/sourcegraph/issues/59308
Test plan
unit tests updated
manual test using
sg start- extension didn't attempt to search embeddings because they are disabled.manual test using
sg start dotcom- extension saw embeddings enabled for repo and searched successfully