This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Check for nodes length before access#59420
Merged
Merged
Conversation
eseliger
approved these changes
Jan 9, 2024
Member
Can you take a look at that, or file a ticket for us? |
Contributor
Author
|
@eseliger yep will do! |
Contributor
ggilmore
approved these changes
Jan 9, 2024
…/fix-perforce-repo-commit-error
…/fix-perforce-repo-commit-error
…urcegraph/sourcegraph into pjlast/fix-perforce-repo-commit-error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59421
Closes #59422
At the moment, access to Perforce depots can be broken, as seen on S2: https://sourcegraph.sourcegraph.com/perforce-sgdev-org/go
This PR resolves the issue by checking the array length of the history nodes before indexing it. However, there might be a different underlying issue here, since I'm not sure if these nodes should ever be empty.
Test plan
Tested on my local instance