This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Remove experimental indexRepositoryName for rust packages#59176
Merged
Conversation
Discussed this with Olaf and Thorsten before: The way this repo is cloned on gitserver is using the API in an illegal way in that it assumes that repos without an entry in the repo table can just be cloned and will stay. However, gitserver eventually deletes those repos again if there's no DB match for them. This is blocking making improvements to tracking repositories on disk because it would mean no entry in the DB is found, and never worked reliably for on-prem instances due to the purge worker eliminating untracked repos like this one.
560dd2a to
a36b8e8
Compare
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 4f6cdb6...a36b8e8.
|
olafurpg
approved these changes
Jan 3, 2024
olafurpg
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍🏻 Thank you for following up on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed this with Olaf and Thorsten before:
The way this repo is cloned on gitserver is using the API in an illegal way in that it assumes that repos without an entry in the repo table can just be cloned and will stay.
However, gitserver eventually deletes those repos again if there's no DB match for them.
This is blocking making improvements to tracking repositories on disk because it would mean no entry in the DB is found, and never worked reliably for on-prem instances due to the purge worker eliminating untracked repos like this one.
Test plan
Very self-contained change. Relying on CI.