This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.2] Updating an code host config maintains the correct unrestricted…#58795
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 30dea0d...4d7d122.
|
Contributor
keegancsmith
approved these changes
Dec 6, 2023
| // `Unrestricted` and `HasWebhooks`. | ||
| func (e *externalServiceStore) recalculateFields(es *types.ExternalService, rawConfig string) error { | ||
| es.Unrestricted = !envvar.SourcegraphDotComMode() && !gjson.Get(rawConfig, "authorization").Exists() | ||
| func calcUnrestricted(config string) bool { |
Member
There was a problem hiding this comment.
I know this is a backport, so treat this as a driveby followup. But the mutliple checks on dotcom make this a little tricky to read. Seems like you could do something like "if dotcom return true" and then the rest of the logic may also be easier to read.
Contributor
Author
There was a problem hiding this comment.
Yeah gotcha, thanks! I'll make a follow-up!
Member
|
CI is not pleased. |
Contributor
Author
|
@keegancsmith I see in the test I added I depended on a new field that wasn't backported. Updated the test, so 🤞 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the logic that determines whether or not a code host connection is unrestricted differs between the code host connection creation and update code.
Test plan
Tests updated
cc @sourcegraph/release-guild