This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.2] Update Azure OpenAI provider to use azure go client and support additional auth methods (#58289)#58472
Merged
Merged
Conversation
Contributor
added 3 commits
November 28, 2023 09:56
f97d55f to
b0b6357
Compare
added 2 commits
November 28, 2023 10:25
emidoots
approved these changes
Nov 28, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the Azure OpenAI provider to use Azure's go client for the purpose of supporting additional auth methods beyond the API Key. When the Access token is not specified AzureDefaultCredentials are used which are tried in the following order:
az loginresolves https://github.com/sourcegraph/sourcegraph/issues/58301
cc @sourcegraph/release-guild
Test plan
Update tests
Tested chat & autocomplete with both API Key and default credentials
Verified auth errors after
az logoutEmbedded multiple repos
Checked embeddings search results used with chat request