Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

[Backport 5.2] Cody: Update Bedrock endpoint to match documentation#58040

Merged
keegancsmith merged 1 commit into
5.2from
backport-58028-to-5.2
Nov 1, 2023
Merged

[Backport 5.2] Cody: Update Bedrock endpoint to match documentation#58040
keegancsmith merged 1 commit into
5.2from
backport-58028-to-5.2

Conversation

@sourcegraph-release-bot

Copy link
Copy Markdown
Collaborator

GA documentation for AWS Bedrock lists a different endpoint for InvokeModel & InvokeModelWithResponseStream this updates the endpoint building logic to match the documentation.

Test plan

Manually tested Autocomplete & chat against internal Bedrock instance
<!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles

Why does it matter?

These test plans are there to demonstrate that are following industry standards which are important or critical for our customers.
They might be read by customers or an auditor. There are meant be simple and easy to read. Simply explain what you did to ensure
your changes are correct!

Here are a non exhaustive list of test plan examples to help you:

  • Making changes on a given feature or component:
    • "Covered by existing tests" or "CI" for the shortest possible plan if there is zero ambiguity
    • "Added new tests"
    • "Manually tested" (if non trivial, share some output, logs, or screenshot)
  • Updating docs:
    • "previewed locally"
    • share a screenshot if you want to be thorough
  • Updating deps, that would typically fail immediately in CI if incorrect

update bedrock endpoint to match GA documentation

(cherry picked from commit 953e02a)
@sourcegraph-bot

Copy link
Copy Markdown
Contributor

📖 Storybook live preview

@chwarwick chwarwick requested a review from camdencheek November 1, 2023 12:30
@keegancsmith keegancsmith merged commit eb6d06d into 5.2 Nov 1, 2023
@keegancsmith keegancsmith deleted the backport-58028-to-5.2 branch November 1, 2023 14:07
@varungandhi-src varungandhi-src mentioned this pull request Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants