Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

[Backport 5.2] Add options to configure internal repo handling for GitLab#58012

Merged
camdencheek merged 2 commits into
5.2from
backport-57858-to-5.2
Nov 1, 2023
Merged

[Backport 5.2] Add options to configure internal repo handling for GitLab#58012
camdencheek merged 2 commits into
5.2from
backport-57858-to-5.2

Conversation

@sourcegraph-release-bot

@sourcegraph-release-bot sourcegraph-release-bot commented Oct 31, 2023

Copy link
Copy Markdown
Collaborator

Closes #57804

This PR adds an option to GitLab code host connections called markInternalReposAsPublic, which sets the visibility of all internal repos added by this code host connection to true, and an option to the GitLab auth provider called syncInternalRepoPermissions. syncInternalRepoPermissions are true by default, and can be set to false to optimise systems where markInternalReposAsPublic is set to true.

Test plan

Unit tests updated. Set up and tested locally as well.

<!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles

Why does it matter?

These test plans are there to demonstrate that are following industry standards which are important or critical for our customers.
They might be read by customers or an auditor. There are meant be simple and easy to read. Simply explain what you did to ensure
your changes are correct!

Here are a non exhaustive list of test plan examples to help you:

  • Making changes on a given feature or component:
    • "Covered by existing tests" or "CI" for the shortest possible plan if there is zero ambiguity
    • "Added new tests"
    • "Manually tested" (if non trivial, share some output, logs, or screenshot)
  • Updating docs:
    • "previewed locally"
    • share a screenshot if you want to be thorough
  • Updating deps, that would typically fail immediately in CI if incorrect

Preview 🤩

Preview Link

@sourcegraph-release-bot sourcegraph-release-bot requested review from a team and pjlast October 31, 2023 12:38
@sourcegraph-release-bot sourcegraph-release-bot added cla-signed backports team/source Tickets under the purview of Source - the one Source to graph it all backported-to-5.2 labels Oct 31, 2023
@sourcegraph-bot

sourcegraph-bot commented Oct 31, 2023

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 2e020a2...84ca45d.

Notify File(s)
@eseliger internal/repos/gitlab.go
internal/repos/gitlab_test.go
@sourcegraph/delivery doc/admin/auth/index.md
doc/admin/external_service/gitlab.md
@unknwon cmd/repo-updater/internal/authz/integration_test.go
internal/authz/providers/authz_test.go
internal/authz/providers/authz_test.go
internal/authz/providers/gitlab/authz.go
internal/authz/providers/gitlab/authz.go
internal/authz/providers/gitlab/oauth.go
internal/authz/providers/gitlab/oauth.go
internal/authz/providers/gitlab/oauth_test.go
internal/authz/providers/gitlab/oauth_test.go
internal/authz/providers/gitlab/sudo.go
internal/authz/providers/gitlab/sudo.go
internal/authz/providers/gitlab/sudo_test.go
internal/authz/providers/gitlab/sudo_test.go

@sourcegraph-bot

sourcegraph-bot commented Oct 31, 2023

Copy link
Copy Markdown
Contributor

📖 Storybook live preview

@camdencheek camdencheek enabled auto-merge (squash) October 31, 2023 21:43
@camdencheek camdencheek merged commit ec96a15 into 5.2 Nov 1, 2023
@camdencheek camdencheek deleted the backport-57858-to-5.2 branch November 1, 2023 08:27
@varungandhi-src varungandhi-src mentioned this pull request Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backported-to-5.2 backports cla-signed team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants