This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.2] Add options to configure internal repo handling for GitLab#58012
Merged
Conversation
(cherry picked from commit 2ea61e5)
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 2e020a2...84ca45d.
|
Contributor
camdencheek
approved these changes
Oct 31, 2023
pjlast
approved these changes
Nov 1, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57804
This PR adds an option to GitLab code host connections called
markInternalReposAsPublic, which sets the visibility of all internal repos added by this code host connection totrue, and an option to the GitLab auth provider calledsyncInternalRepoPermissions.syncInternalRepoPermissionsare true by default, and can be set to false to optimise systems wheremarkInternalReposAsPublicis set to true.Test plan
Unit tests updated. Set up and tested locally as well.
<!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles
Why does it matter?
These test plans are there to demonstrate that are following industry standards which are important or critical for our customers.
They might be read by customers or an auditor. There are meant be simple and easy to read. Simply explain what you did to ensure
your changes are correct!
Here are a non exhaustive list of test plan examples to help you:
-->
Backport 2ea61e5 from Add options to configure internal repo handling for GitLab #57858
Preview 🤩
Preview Link