WIP: spiked tree-sitter-dart impl#57987
Conversation
|
We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added. Sourcegraph teammates should refer to Accepting contributions for guidance. |
| tree-sitter-rust = "0.20.3" | ||
| tree-sitter-typescript = "0.20.2" | ||
|
|
||
| tree-sitter-dart = { git = "https://github.com/matthewnitschke-wk/tree-sitter-dart", rev = "84440dc48288890dddb63345b6e1dd0168338c1a" } |
There was a problem hiding this comment.
As luck would have it, @valerybugakov just fixed it :) UserNobody14/tree-sitter-dart#59
So this can be reverted back to upstream.
There was a problem hiding this comment.
Oh! Fantastic! Thanks for looking
There was a problem hiding this comment.
Actually, it looks like we're forking it as well: https://github.com/sourcegraph/tree-sitter-dart
I'll let Valery to speak to the reasons why, but I was only able to run tests on your PR using the forked grammar (the upstream failed to build the bindings)
There was a problem hiding this comment.
Sorry! Just seeing this now!
Awesome! I was running into that same problem, but couldn't spend the time figuring out what was going on. Was able to update the fork to sourcegraph's, and successfully generate the snapshots
|
In terms of generating snapshots, I believe you can
And then accept the snapshot, and check it in |
|
We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added. Sourcegraph teammates should refer to Accepting contributions for guidance. |
|
We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added. Sourcegraph teammates should refer to Accepting contributions for guidance. |
|
We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added. Sourcegraph teammates should refer to Accepting contributions for guidance. |
|
Closing in favor of https://github.com/sourcegraph/sourcegraph/pull/58480, which has signed cla |
Spike implementation of tree-sitter support for dart, further described in this issue: https://github.com/sourcegraph/sourcegraph/issues/57880
Test plan