This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.2] Code monitors: fix a bunch of stuff#57599
Merged
Conversation
- Fixes an issue where creating a monitor will fail due to concurrent transaction usage - Fixes an issue where a timeout will cause a monitor to continually get re-run - Cleans up some old feature flags - Cleans up some dead code (cherry picked from commit afd3156)
camdencheek
approved these changes
Oct 13, 2023
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 461cf0e...8625505.
|
Contributor
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I apologize for the multi-focused PR, but a few of these fixes bled into each other.
Comments inline.
Test plan
Manually tested that monitors still work. Existing tests cover standard cases, and I updated the test that checks that a failure logs a message.
Backport afd3156 from #57546