This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.2] [bug] Display user permissions even if the GQL resolver has errors#57385
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 5775b5e...ea23794.
|
Contributor
keegancsmith
reviewed
Oct 6, 2023
keegancsmith
left a comment
Member
There was a problem hiding this comment.
LGTM but changelog is borked and should be under 5.2.1 unreleased
keegancsmith
approved these changes
Oct 16, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where admins can't view a user's permissions if they don't have access to all of the repos a user has access to.
Previously the page would just load forever, now admins are told they can't see the repo:
Test plan
Manual tests
Backport 18c70e0 from #57375