This repository was archived by the owner on Sep 30, 2024. It is now read-only.
grpc: enable by default by inverting experimental feature flag#56738
Merged
Conversation
ced6523 to
889b61a
Compare
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 03ac5c2...889b61a.
|
efritz
approved these changes
Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables gRPC by default. All the same environment variables / site configuration options still work. The only difference is that the default behavior is to leave gRPC enabled unless the site configuration option / env var is explicitly set.
This PR should not be backported to the 5.1.X branch.
Test plan
Unit tests / CI
Note: a number of tests needed a bit of setup-tweaking since they were only running HTTP codepaths before.