This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.1] Add feature flags to perms syncer context#56501
Merged
Conversation
(cherry picked from commit a29b68f)
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 27596b4...be88ecf.
|
Contributor
pjlast
approved these changes
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FetchUserPermissions code for GitLab never had the feature flags added to the context, so the feature flag was not working as intended.
Loom:
https://www.loom.com/share/646c86923b7f4d70ad6e881b67794f6a
Test plan
Tests passing. Added GitLab integration tests to test feature flag.
<!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles
Why does it matter?
These test plans are there to demonstrate that are following industry standards which are important or critical for our customers.
They might be read by customers or an auditor. There are meant be simple and easy to read. Simply explain what you did to ensure
your changes are correct!
Here are a non exhaustive list of test plan examples to help you:
-->
Backport a29b68f from Add feature flags to perms syncer context #56492