Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

[Backport 5.1] Add feature flags to perms syncer context#56501

Merged
keegancsmith merged 1 commit into
5.1from
backport-56492-to-5.1
Sep 11, 2023
Merged

[Backport 5.1] Add feature flags to perms syncer context#56501
keegancsmith merged 1 commit into
5.1from
backport-56492-to-5.1

Conversation

@sourcegraph-release-bot

Copy link
Copy Markdown
Collaborator

The FetchUserPermissions code for GitLab never had the feature flags added to the context, so the feature flag was not working as intended.

Loom:
https://www.loom.com/share/646c86923b7f4d70ad6e881b67794f6a

Test plan

Tests passing. Added GitLab integration tests to test feature flag.

<!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles

Why does it matter?

These test plans are there to demonstrate that are following industry standards which are important or critical for our customers.
They might be read by customers or an auditor. There are meant be simple and easy to read. Simply explain what you did to ensure
your changes are correct!

Here are a non exhaustive list of test plan examples to help you:

  • Making changes on a given feature or component:
    • "Covered by existing tests" or "CI" for the shortest possible plan if there is zero ambiguity
    • "Added new tests"
    • "Manually tested" (if non trivial, share some output, logs, or screenshot)
  • Updating docs:
    • "previewed locally"
    • share a screenshot if you want to be thorough
  • Updating deps, that would typically fail immediately in CI if incorrect

@sourcegraph-bot

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 27596b4...be88ecf.

Notify File(s)
@unknwon cmd/repo-updater/internal/authz/BUILD.bazel
cmd/repo-updater/internal/authz/integration_test.go
cmd/repo-updater/internal/authz/perms_syncer.go
cmd/repo-updater/internal/authz/testdata/vcr/TestIntegration_GitLabPermissions/test_gitLabProjectVisibilityExperimental_feature_flag.yaml
internal/authz/providers/gitlab/authz.go
internal/authz/providers/gitlab/authz.go
internal/authz/providers/gitlab/oauth.go
internal/authz/providers/gitlab/oauth.go

@sourcegraph-bot

Copy link
Copy Markdown
Contributor

📖 Storybook live preview

@keegancsmith keegancsmith merged commit a08566b into 5.1 Sep 11, 2023
@keegancsmith keegancsmith deleted the backport-56492-to-5.1 branch September 11, 2023 12:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants