completions: AWS Bedrock integration#56321
Conversation
chwarwick
left a comment
There was a problem hiding this comment.
Nice this looks pretty straight forward to me. Just curious about the anthropic.model vs the anthropic/model used in other places.
| "cody.enabled": true, | ||
| "completions": { | ||
| "provider": "aws-bedrock", | ||
| "chatModel": "anthropic.claude-v2", |
There was a problem hiding this comment.
Is the anthropic. the format that bedrock uses? Would it make sense to keep it consistent with how the sourcegraph provider works with MODEL_PROVIDER/MODEL_NAME? I'm thinking about client needs where we want to pick the correct extension autocomplete provider based on the configured provider and model.
There was a problem hiding this comment.
Yeah, this is the format they are using, it's what they show in their UI. I think it would be best to assume that the bedrock provider for now is always just anthropic. Would that work?
There was a problem hiding this comment.
yeah i think if it matches what they have in their ui it's easier for users to just copy that, and we can deal with it.
This adds experimental support for Claude via AWS Bedrock as the completions provider.
I added some experimental docs for it, and ran through it with a bunch of repos and queries, seems to be on-par with the Anthropic provider.
Test plan
Verified manually using our AWS deployment.