This repository was archived by the owner on Sep 30, 2024. It is now read-only.
graphqlbackend: update throttled to use Ctx stores (#54748)#56091
Merged
Conversation
coury-clark
approved these changes
Aug 21, 2023
It seems we were using a weird version of throttled which I don't think was actually based on the v2 series correctly. This updates us to the latest version and moves us away from the removed struct GCRARateLimiter and the deprecated interface GCRAStore. I came across this while attempting to update deps and getting failing compiles. Test Plan: we have unit tests for this, so CI. (cherry picked from commit c390e4b)
877aa48 to
9433974
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of https://github.com/sourcegraph/sourcegraph/pull/54748, since there was a merge conflict.
It seems we were using a weird version of throttled which I don't think was actually based on the v2 series correctly. This updates us to the latest version and moves us away from the removed struct GCRARateLimiter and the deprecated interface GCRAStore.
I came across this while attempting to update deps and getting failing compiles.
Test Plan: we have unit tests for this, so CI.
(cherry picked from commit c390e4b)
Test plan
Original CI