This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.1] Backport #54854 into 5.1#55261
Merged
Merged
Conversation
Moving licensing checks to a singleton worker job. This way we make sure that only one license check API call is being made on each 12-hour tick. Previously this lived in a frontend service. If multiple frontend services were running, this would fire multiple requests, which is undesirable from many points of view - waste of resources, waste of bandwidth, potential concurrency issues. Having it fire multiple times would also break an assumption that we have in the license check handler on dotcom. For checking if same site_id is used on multiple instances, we assume that the time difference between license check calls would be roughly 10-12 hours. Calling twice in the same second breaks this assumption. Tested locally that the worker starts (cherry picked from commit 6732a5f)
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 65b0a23...962f71f.
|
Contributor
kopancek
commented
Jul 25, 2023
kopancek
left a comment
Contributor
Author
There was a problem hiding this comment.
Fixed conflicts, seems to be working OK for me locally
unknwon
approved these changes
Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #54854 into 5.1
Test plan
backport PR, N/A