This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[bitbucket cloud] Code host connection updates#55095
Merged
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff cd7c601...20585fb.
|
Contributor
sashaostrikov
approved these changes
Jul 19, 2023
sashaostrikov
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Left a minor suggestion.
kopancek
approved these changes
Jul 19, 2023
ca834b0 to
20585fb
Compare
eseliger
reviewed
Jul 19, 2023
| ### Changed | ||
|
|
||
| - OpenTelemetry Collector has been upgraded to v0.81, and OpenTelemetry packages have been upgraded to v1.16. [#54969](https://github.com/sourcegraph/sourcegraph/pull/54969), [#54999](https://github.com/sourcegraph/sourcegraph/pull/54999) | ||
| - Bitbucket Cloud code host connections no longer automatically syncs the repository of the username used. The appropriate workspace name will have to be added to the `teams` list if repositories for that account need to be synced. [#55095](https://github.com/sourcegraph/sourcegraph/pull/55095) |
Member
There was a problem hiding this comment.
should we call this out somewhere more prominently as well? I'm scared that this might cause some mass repo deletions for some users, but maybe I'm wrong here.
Contributor
There was a problem hiding this comment.
Yeah, +1 on this. This is a regression in behaviour, right? Suddenly your repositories disappear when you update and you don't know why. This makes me scared enough that I wonder whether we shouldn't revert this change. Or was there thinking behind as to why this isn't risky?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54968
This PR does a few things to better the Bitbucket Cloud connection experience:
Accountscope on the App Password, and we use the List Repositories endpoint to verify a connection instead.Test plan
Update unit tests