This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.1] [fix] permission sync is now scheduled correctly for new users#54274
Merged
Conversation
Contributor
kopancek
approved these changes
Jun 27, 2023
Member
|
@kopancek CI is not happy. I have enabled auto-merge though so once you resolve it, it will land. Edit: I retried since errors look unrelated. |
Contributor
Thanks @keegancsmith , weird thing is that those failing tests pass locally when I try to run |
d3867ce to
cf2a754
Compare
Previously we relied on users_with_no_perms query to schedule new users. However this might not schedule anything for the new user, because the user might already have permissions granted from pending permissions. This resulted in sync job for the user never reaching the permission_sync_jobs table in the database. Which in turn also resulted in user not getting the permissions that they needed as fast as possible. It also resutled in scheduled permission syncs not being scheduled at all for the user, since the schedule depends on a record in permission_sync_jobs table for each user. ## Test plan unit tests (cherry picked from commit c68432a)
a1841dc to
e11e26e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we relied on users_with_no_perms query to schedule new users. However this might not schedule anything for the new user, because the user might already have permissions granted from pending permissions.
This resulted in sync job for the user never reaching the permission_sync_jobs table in the database. Which in turn also resulted in user not getting the permissions that they needed as fast as possible. It also resutled in scheduled permission syncs not being scheduled at all for the user, since the schedule depends on a record in permission_sync_jobs table for each user.
Test plan
unit tests
Backport c68432a from #54258