This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.1] batch-changes: ensure PR is only approved after code owner review#54174
Merged
Conversation
…3601) Attempts to address https://github.com/sourcegraph/sourcegraph/issues/50874 By getting the "ReviewDecision" from a PR which is only "APPROVED" once a codeowner (if required) has reviewed the PR, otherwise this field returns "REVIEW_REQUIRED" or "CHANGES_REQUSTED". Given there is a no longer a requirement for events on github PRs, we don't need to calculate if the changeset is older than events before computing the state. ## Test plan CI passing, tested locally with a repo on ghe.sgdev.org with a codeowners file (cherry picked from commit 6ea307e)
davejrt
approved these changes
Jun 26, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to address https://github.com/sourcegraph/sourcegraph/issues/50874
By getting the "ReviewDecision" from a PR which is only "APPROVED" once a codeowner (if required) has reviewed the PR, otherwise this field returns "REVIEW_REQUIRED" or "CHANGES_REQUSTED".
Given there is a no longer a requirement for events on github PRs, we don't need to calculate if the changeset is older than events before computing the state.
Test plan
CI passing, tested locally with a repo on ghe.sgdev.org with a codeowners file
Backport 6ea307e from #53601