This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.1] internal/trace: remove net/trace integration#53889
Merged
Conversation
Follow-up from https://github.com/sourcegraph/sourcegraph/pull/53435#issuecomment-1597050970 and INC-214 - this removes `net/trace` instrumentation entirely in the next release. It seems [this gets low usage and may be difficult to use](https://github.com/sourcegraph/sourcegraph/pull/53795#pullrequestreview-1489890896), and it seems to introduce some risk and overhead. This will also make it easier to drop our internal trace wrapper entirely and/or integrate it as part of OpenTelemetry's APIs instead of having a proprietary way of doing traces. ## Test plan Already tested in https://github.com/sourcegraph/sourcegraph/pull/53435 (cherry picked from commit 61ce005)
bobheadxi
approved these changes
Jun 21, 2023
Contributor
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 072fa25...e724104.
|
282562c to
e724104
Compare
camdencheek
approved these changes
Jun 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from https://github.com/sourcegraph/sourcegraph/pull/53435#issuecomment-1597050970 and INC-214 - this removes
net/traceinstrumentation entirely in the next release.It seems this gets low usage and may be difficult to use, and it seems to introduce some risk and overhead. This will also make it easier to drop our internal trace wrapper entirely and/or integrate it as part of OpenTelemetry's APIs instead of having a proprietary way of doing traces.
Test plan
Already tested in https://github.com/sourcegraph/sourcegraph/pull/53435
Backport 61ce005 from #53795