This repository was archived by the owner on Sep 30, 2024. It is now read-only.
github app: toggle app default visibility#53286
Merged
Merged
Conversation
31 tasks
Contributor
f9ebb3e to
2409ffc
Compare
st0nebreaker
approved these changes
Jun 12, 2023
st0nebreaker
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this! And the clear instructions/descriptions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
<Checkbox />to the Create GitHub App form for toggling the default visibility of the App from private to public. This will populate the value in the App manifest.I also added a short explanation about GitHub App installations and the ability to install them in multiple places if the app is public vs. private to the main GitHub App page, with a link the part of our docs that describes it in more detail.
Demo
Screen.Recording.2023-06-09.at.9.46.40.PM.mov
And a screenshot from the normal Repos create flow:
Test plan
Manual testing.