This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.0] Fix broken diff search if sub-repo perms are enabled#53218
Merged
Conversation
(cherry picked from commit 24c34a1)
pjlast
approved these changes
Jun 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sub-repo permissions are enabled, the sub-repo permissions filter would be applied to repositories where sub-repo permissions are relevant. This lead to
type:diffsearch being broken when sub-repo permissions are enabled, since it would try to filter repositories for which sub-repo permissions do not apply.This PR changes the check to confirm that sub-repo permissions are enabled for the repository being filtered before doing the sub-repo filter, and if the repository does not have sub-repo permissions enabled, the repository is skipped.
Test plan
Verified with manual checks. Added unit test.
<!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
Backport 24c34a1 from #53210