This repository was archived by the owner on Sep 30, 2024. It is now read-only.
github app: better "delete App" UX#53203
Merged
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 12fadf2...bd2ff2f.
|
Contributor
047e6b4 to
bd2ff2f
Compare
BolajiOlajide
approved these changes
Jun 9, 2023
st0nebreaker
approved these changes
Jun 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This branch is temporarily based on https://github.com/sourcegraph/sourcegraph/pull/52979 to avoid merge conflicts with myself. I'll rebase it on the feature branch once that's merged.
Refactors "delete App" action logic to a shared
<Modal />component and uses the extra real estate of the modal to explain that this only deletes the app on Sourcegraph, not on GitHub. Demo:Screen.Recording.2023-06-08.at.7.18.45.PM.mov
Test plan
Manual testing.