This repository was archived by the owner on Sep 30, 2024. It is now read-only.
github app: no editing support for "batches" app#53130
Merged
Merged
Conversation
bb05281 to
f5446cc
Compare
f5446cc to
9a35ccb
Compare
Contributor
BolajiOlajide
approved these changes
Jun 8, 2023
BolajiOlajide
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
Added a comment about code readability but I'm not sure my suggestion is even better, feel free to ignore.
| <AuthProviderMessage app={app} id={appID} /> | ||
| </> | ||
| )} | ||
| {!app ? null : app.domain !== GitHubAppDomain.REPOS ? ( |
Contributor
There was a problem hiding this comment.
This was a bit hard for me to understand at first glance. Is there a way we can simplify it?
Contributor
There was a problem hiding this comment.
I was thinking something like what I have below:
{app && app.domain !== GitHubAppDomain.REPOS && ()}
{app && app.domain !== GitHubAppDomain.BATCHES && ()}But at another glance, I don't even know if it's better. Feel free to ignore this.
Contributor
Author
There was a problem hiding this comment.
Haha I actually had it this way at first, too, but I couldn't decide what felt better. 😂 I'll leave it for now but I think we'll be able to clean this up a bit when we built multi-org installations support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/sourcegraph/sourcegraph/issues/52341.
Tip: Make sure to view the PR diff with whitespace changes hidden. 🙂
There should not be any direct links to this page for Batches domain GitHub Apps, but in case a user were to manually plug in this URL, we want the page contents to reflect that at present, we don't support additional configuration or install management of Batches domain GH Apps. We may decide to revisit this in the future.
Test plan
Manually verified that visiting a route for a Batches app appeared as in the screenshot above, and that a Repos app appeared as before.