This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.0] [fix] use same where condition in user analytics as in pings for mau#52608
Merged
Conversation
kopancek
approved these changes
May 30, 2023
…52306) Previously we used a different condition to calculate the MAU and other stats in user analytics page. Now we use the same condition as we use for pings. We also calculate everything using UTC now, so both should give the same value. ## Test plan Tested locally and also with data from Tinder. The new query for MAU seems to be returning the correct data for us, I manually cross-referenced the old query vs the new. Apart from the timezone difference, the new query is more precise as in it filters the sourcegraph-operator users and non-user events in the same way as we do for the pings. (cherry picked from commit 8d04aa1)
b7b302f to
5d2e7a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we used a different condition to calculate the MAU and other stats in user analytics page. Now we use the same condition as we use for pings. We also calculate everything using UTC now, so both should give the same value.
Test plan
Tested locally and also with data from Tinder. The new query for MAU seems to be returning the correct data for us, I manually cross-referenced the old query vs the new. Apart from the timezone difference, the new query is more precise as in it filters the sourcegraph-operator users and non-user events in the same way as we do for the pings.
Backport 8d04aa1 from #52306