Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

(chore) remove "repo:has(), repo:has.key() and repo:has.tag()" from autocomplete suggestion list#52249

Merged
erzhtor merged 2 commits into
mainfrom
erzhtor/remove-old-repo-meta-filter-syntax-from-suggestions
May 22, 2023
Merged

(chore) remove "repo:has(), repo:has.key() and repo:has.tag()" from autocomplete suggestion list#52249
erzhtor merged 2 commits into
mainfrom
erzhtor/remove-old-repo-meta-filter-syntax-from-suggestions

Conversation

@erzhtor

@erzhtor erzhtor commented May 22, 2023

Copy link
Copy Markdown
Contributor

Follow-up https://github.com/sourcegraph/sourcegraph/pull/52150.

This PR because repo:has(), repo:has.key() and repo:has.tag() are now deprecated, it removes them autocomplete suggestion list as well as search reference sidebar.

Test plan

  • sg start
  • Start typing repo:has and you should not get above filter suggestions

Screenshot

Before After
image image
image image

…utocomplete suggestion list

(chore) also remove from search reference sidebar
@erzhtor erzhtor added the merge-on-any-approve Whomever approves the PR can merge without waiting for the author label May 22, 2023
@erzhtor erzhtor requested review from a team, camdencheek, ryphil and toolmantim May 22, 2023 11:45
@erzhtor erzhtor self-assigned this May 22, 2023
@cla-bot cla-bot Bot added the cla-signed label May 22, 2023
@sourcegraph-bot

sourcegraph-bot commented May 22, 2023

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff c2b8970...e633a41.

Notify File(s)
@fkling client/shared/src/search/query/completion.test.ts
client/shared/src/search/query/completion.test.ts
client/shared/src/search/query/predicates.ts
client/shared/src/search/query/predicates.ts

@sourcegraph-buildkite

sourcegraph-buildkite commented May 22, 2023

Copy link
Copy Markdown
Collaborator

Bundle size report 📦

Initial size Total size Async size Modules
-0.04% (-1.11 kb) -0.01% (-1.90 kb) -0.01% (-0.79 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits e633a41 and 760db94 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@sourcegraph-bot

sourcegraph-bot commented May 22, 2023

Copy link
Copy Markdown
Contributor

📖 Storybook live preview

@erzhtor erzhtor merged commit 0ed8fe3 into main May 22, 2023
@erzhtor erzhtor deleted the erzhtor/remove-old-repo-meta-filter-syntax-from-suggestions branch May 22, 2023 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed merge-on-any-approve Whomever approves the PR can merge without waiting for the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants