Increase minimum supported redis version from 5.0 -> 6.2#52248
Conversation
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 15db831...8cdd6d5.
|
keegancsmith
left a comment
There was a problem hiding this comment.
LGTM. Please document this in the changelog as well.
Are all the hosted redis providers (eg aws) on 7 yet? I see it was only released a year ago, so just making sure we aren't potentially causing an issue here.
also cc @sourcegraph/delivery
|
Good catch - AWS ElastiCache supports Redis 7 but GCS Memorystore for Redis only supports up to 6.2. While we could ship Redis 7 and take care not to add any v7-specific features, the better option is going to be switching to Wolfi's Redis 6.2 package and setting 6.2 as our minimum supported version. This will still be fully patched, but ensures we can't accidentally ship v7 features. |
keegancsmith
left a comment
There was a problem hiding this comment.
neat how easy that was to change for wolfi. nice stuff.
We currently don't use any 7.0 features, but the move to Wolfi will include a switch to Redis 7.0 so all future development will be tested against that version.Initially we had planned to updated Redis to 7.0, but GCS Memorystore for Redis only supports up to 6.2. As a result, we're only upgrading to Redis 6.2.
Test plan