This repository was archived by the owner on Sep 30, 2024. It is now read-only.
batches: remove rollout windows config from jscontext and DropdownButton#51752
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff e14f783...ab9ec8c.
|
Contributor
Collaborator
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits ab9ec8c and e14f783 or learn more. Open explanation
|
courier-new
approved these changes
May 15, 2023
courier-new
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just a couple minor points of feedback.
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
c3f2b76 to
ab9ec8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts#50471 and removes all occurrences of
batchChangesRolloutWindowsfromwindow.context.Test plan
console.log(window.context)shouldn't containbatchChangesRolloutWindows