Codenotify: Notifying subscribers in CODENOTIFY files for diff a82352a...071825e.

Bundle size report 📦

Look at the Statoscope report for a full comparison between the commits 071825e and 1004a84 or learn more.

👏🏼

The original intention was that each whole badge was clickable (say, with a darker background color change) — but only linking the text might work when we want to link the value too, and not just the key. Which leads to my next question…

Any reason we haven't linked the "value" part of the badge yet? Or is that coming in a follow-up? Feels odd without that. e.g. for "license: mit" we'd link "license" to repo:has.meta(license) and "mit" to repo:has.meta(license:mit) (or whatever the final search names we chose were)

Thanks @toolmantim, for the reviews.

Any reason we haven't linked the "value" part of the badge yet? Or is that coming in a follow-up? Feels odd without that. e.g. for "license: mit" we'd link "license" to repo:has.meta(license) and "mit" to repo:has.meta(license:mit) (or whatever the final search names we chose were)

1. That is easily doable, however, I'm just worried about the UX, will it be straight forward that two parts of the same badge be different links?

The original intention was that each whole badge was clickable (say, with a darker background color change) — but only linking the text might work when we want to link the value too, and not just the key. Which leads to my next question…

2. My bad, I thought that we agreed on this approach. We can make the badge to make a link which will lead to repo:has.key() or repo:has(key:value depending on whether the metadata consists of key-value pair or just key.

I think 2nd makes more sense (with making the whole badge clickable), I will update to follow this logic. But let me know if you think, we should consider 1st point/option too.

@toolmantim, updated to make whole badge clickable and make link filter different based on metadata value presence 042149b5e11faf7fac418252661b494180fca69b.

I'll trust your gut feeling on the two links in the one badge being confusing!

And sorry about not being clear on the style! I assumed we would be going with the standard <Badge as={Link}> that I spotted in the following, but I should have been clear about that earlier:

https://github.com/sourcegraph/sourcegraph/blob/df2d87dda19f9be93b59d9ba48a3dc07d293d676/client/wildcard/src/components/Badge/Badge.story.tsx#L57

Could we make the whole thing clickable, similar to how it works in the Storybook example? I tried to the change myself, but I think it's too much component rejigging with where the link is defined, so might need to get your help.

Also… giving it a go locally… I realised that if you're on a repo root page, I think we should to strip the repo off the URL from the badge links, so you can easily navigate to other repositories (which was the intention). wdyt?

Thanks @toolmantim for the review. Addressed both feedback items.

📖 Storybook live preview