This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Remove RateLimitWatcher, keep BasicLimitWatcher#51087
Merged
Merged
Conversation
The `RateLimitWatcher` was unused. According to 8726839 the `BasicLimitWatcher` was introduced as a simplified version: > There was already a much more sophisticated, but currently disabled, > rate limiter in place that currently undergoes testing. This new > limiter is a heavily simplified version of the existing limiter which we > can use for the time being. In the 2 years since no one enabled the other rate limiter. Looks like we might need something like the more sophisticated rate limiter again, but I'm unsure what the requirements are and what held the "more sophisticated" rate limiter back.
eseliger
approved these changes
Apr 25, 2023
stefanhengl
approved these changes
Apr 25, 2023
stefanhengl
left a comment
Member
There was a problem hiding this comment.
Quoting from my PR you referenced in the description
The basic rate limiter from this PR was introduced to fight an attacker from last year. I believe the disabled limiter was more sophisticated and tried to estimate things like a "query cost". I am not aware that any work on rate limiting happened since then.
That's still accurate AFAIK.
Contributor
Author
Yep. Does that mean we should keep it around here? |
Member
No no. Definitely remove the unused one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RateLimitWatcherwas unused. According to8726839 the
BasicLimitWatcherwas introduced as a simplified version:In the 2 years since no one enabled the other rate limiter.
Looks like we might need something like the more sophisticated rate limiter again, but I'm unsure what the requirements are and what held the "more sophisticated" rate limiter back.
Test plan