This repository was archived by the owner on Sep 30, 2024. It is now read-only.
batches: use String.replaceAll to substitute spaces on batch change name input#51071
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff ebeeb11...403df93.
|
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 403df93 and ebeeb11 or learn more. Open explanation
|
st0nebreaker
approved these changes
Apr 25, 2023
st0nebreaker
left a comment
Contributor
There was a problem hiding this comment.
Good catch! I spaced on this case in implementation
Contributor
Author
Yeah you should have dashed on it. 😜 |
Contributor
Lol the pun gun is out ! 🔫 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to https://github.com/sourcegraph/sourcegraph/pull/50825/files?w=1#r1175947173. This makes sure we replace all spaces that occur in the new name input value, not just the first occurrence, for example if the user copy+pastes all or part of the batch change name.
Test plan
Manually tested.