This repository was archived by the owner on Sep 30, 2024. It is now read-only.
batches: Replace white spaces with a dash in Batch Change Name input#50825
Merged
Conversation
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 4d140b3 and 9239bdd or learn more. Open explanation
|
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff af62faf...4d140b3.
|
BolajiOlajide
approved these changes
Apr 18, 2023
courier-new
reviewed
Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #50353. Gives the user a more successful path while naming their batch change. Spaces are not allowed, any space character inserted is replaced with a dash now.
Paired @st0nebraker & @adeola-ak
Note: We didn't think the input description should be updated. The user can infer that spaces are being replaced by dashes because of the action & rules stated. Let us know if you think the description should be updated with anything specific.
Screen.Recording.2023-04-18.at.12.08.48.PM.mov
Test plan