This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Backport 50668 to 5.0#50720
Merged
Merged
Conversation
## Test plan <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> * Non-dotcom instances should work as before * If `cody-experimental` feature flag is not created, dotcom users will not be able to use completions endpoint and embeddings GQL API * If `cody-experimental` feature flag override is created for a user, that user should have access to completions and embeddings on dot com * Unauthorized users should not have access to either (cherry picked from commit 3c90dda)
…mental" feature flag (#50668) Addresses https://github.com/sourcegraph/sourcegraph/issues/50632 To enable this, the Sourcegraph site admin must do the following: 1. Set `"codyRestrictUsersFeatureFlag": true` in site config under `"experimentalFeatures"`. 2. Create a feature flag called `cody-experimental` through https://$SOURCEGRAPH_HOST/site-admin/feature-flags 3. Set the default value of the feature flag to `false` and then add overrides to `true` for specific users, as we do on sourcegraph.com (cherry picked from commit 0b460b4)
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 7754870...e1e0634.
|
Contributor
|
Codenotify: Notifying subscribers in OWNERS files for diff 7754870...e1e0634.
|
beyang
approved these changes
Apr 17, 2023
Contributor
Member
Author
|
Yes it will! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports both
to 5.0. The former is cherry picked to reduce merge conflicts and make potential future cherry picks a bit easier.
I also had to backport adding a bazelignore entry for
client/codybecause I couldn't update the build files on this branch anymore. There seems to have been a few misses in buildfile updates so this PR is unfortunately quite noisy.Test plan
CI and code review.