This repository was archived by the owner on Sep 30, 2024. It is now read-only.
docs: add documentation for login form configuration#50705
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff bdda34a...554c877.
|
pjlast
suggested changes
Apr 17, 2023
pjlast
left a comment
Contributor
There was a problem hiding this comment.
Some language suggestions
Comment on lines
+20
to
+24
| If there are multiple auth providers configured, by default the login form displays a login button for each of them. | ||
| This is displayed in a specific order that is hardcoded in the application. | ||
|
|
||
| To change the order, each auth provider now has an optional `order` parameter. It is an integer and items | ||
| will be sorted in natural order (1, 2, 3, ...). |
Contributor
There was a problem hiding this comment.
Suggested change
| If there are multiple auth providers configured, by default the login form displays a login button for each of them. | |
| This is displayed in a specific order that is hardcoded in the application. | |
| To change the order, each auth provider now has an optional `order` parameter. It is an integer and items | |
| will be sorted in natural order (1, 2, 3, ...). | |
| When multiple auth providers are configured, the default login form displays a login button for each of them. | |
| Each auth provider has an optional `order` parameter. It is an integer and items | |
| will be sorted in natural order (1, 2, 3, ...). |
Contributor
Author
There was a problem hiding this comment.
Reworded it a bit, so that we still keep the portion about default ordering being hardcoded. I'd like to be transparent here, that adding order param is the only way to override that.
Co-authored-by: Petri-Johan Last <petri.last@sourcegraph.com>
Co-authored-by: Petri-Johan Last <petri.last@sourcegraph.com>
Co-authored-by: Petri-Johan Last <petri.last@sourcegraph.com>
Co-authored-by: Petri-Johan Last <petri.last@sourcegraph.com>
Co-authored-by: Petri-Johan Last <petri.last@sourcegraph.com>
pjlast
approved these changes
Apr 17, 2023
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added logs for configuring the login form. Can be seen here.
Test plan
Eyeballing of the rendered docs pages.