batches: display note in dropdown if rollout windows are configured#50608
Conversation
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 9b3d612...87d8077.
|
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 87d8077 and 9b3d612 or learn more. Open explanation
|
BolajiOlajide
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the fix.
d1be677 to
87d8077
Compare
| {action.type === 'publish' && batchChangesRolloutWindows && batchChangesRolloutWindows.length > 0 ? ( | ||
| <small> | ||
| {action.dropdownDescription} <br /> | ||
| <b> |
There was a problem hiding this comment.
Omg sorry I hate to be this person haha but I think we want <strong> here instead of <b>. <b> is mostly for stylistic bold text. It conveys no extra importance or emphasis. <strong> should be used for important text that should be emphasized, and screen readers will convey this as more important text. In this case the note is something we want to emphasize, not just something we're styling differently.
| </H4> | ||
| <Text className="text-wrap text-muted mb-0"> | ||
| <small>{action.dropdownDescription}</small> | ||
| {action.type === 'publish' && batchChangesRolloutWindows && batchChangesRolloutWindows.length > 0 ? ( |
There was a problem hiding this comment.
Separately (and again, I regret only getting this feedback to you after you've merged this 🙈), but I think we want this on the publish as draft action type as well.
closes #48217
checks if rollout windows are configured and displays a note about how changesets are processed if they are
Test plan
Test with and without changesets to see the note
App preview:
Check out the client app preview documentation to learn more.