This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search input: Only insert type:symbol when necessary#50183
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 1d4e0c5...86a6d29.
|
limitedmage
approved these changes
Apr 13, 2023
643739d to
a99f681
Compare
a2c6197 to
62b61c6
Compare
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 86a6d29 and 1d4e0c5 or learn more. Open explanation
|
At the moment symbol suggestions will always insert 'type:symbol', which can produce incorrect queries if the current query already contains a 'type:' filter. This PR builds on top of #50554 and only inserts a 'type:' filter if the relevant branch of the query doesn't already contain one.
51e90e2 to
86a6d29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment symbol suggestions will always insert 'type:symbol', which can produce incorrect queries if the current query already contains a 'type:' filter. This PR builds on top of #50554 and only inserts a 'type:' filter if the relevant branch of the query doesn't already contain one.
sg-search-input-symbol-type.mp4
Test plan
type:symboltype:diffin the query -> only the symbol name (nottype:symbol) is inserted into the inputApp preview:
Check out the client app preview documentation to learn more.