Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

codeintel: Unblock auto-indexing experience frontend#48770

Merged
efritz merged 4 commits into
mainfrom
ef/auto-indexing-updates
Mar 6, 2023
Merged

codeintel: Unblock auto-indexing experience frontend#48770
efritz merged 4 commits into
mainfrom
ef/auto-indexing-updates

Conversation

@efritz

@efritz efritz commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

@umpox had a short list of things he needed from the backend:

  • Expose requestedEnvVars via GraphQL(also also add it to the JSON schema)
  • Expose the Docker image name for indexer types via GraphQL
  • Expose the pre-index commands via GraphQL
{
  inferAutoIndexJobsForRepo(repository: "UmVwb3NpdG9yeToyMTE3NjM4") {
    steps {
      preIndex {
        commands
        image
        root
      }
      index {
        commands
        indexerArgs
        requestedEnvVars
      }
    }
    indexer {
      imageName
    }
  }
}

image

We also agreed to remove shared_steps as a concept from the YAML/JSON configuration as it really muddies up the form-builder type of UX we're going for. This feature appears completely unused.

Test plan

Updated unit tests.

@efritz efritz added team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) team/language-platform labels Mar 6, 2023
@efritz efritz self-assigned this Mar 6, 2023
@cla-bot cla-bot Bot added the cla-signed label Mar 6, 2023
@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Mar 6, 2023

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) -0.00% (-0.06 kb) -0.00% (-0.06 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 2968631 and b44ffe9 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@efritz efritz requested review from Strum355 and cesrjimenez March 6, 2023 21:49
@sourcegraph-bot

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff cdace97...2968631.

Notify File(s)
@Strum355 enterprise/internal/codeintel/autoindexing/internal/jobselector/job_selector.go
enterprise/internal/codeintel/autoindexing/service_test.go
enterprise/internal/codeintel/autoindexing/transport/graphql/codeintel_tree_info_resolver.go
enterprise/internal/codeintel/autoindexing/transport/graphql/precise_based_support_resolver.go
enterprise/internal/codeintel/autoindexing/transport/graphql/precise_indexes.go
enterprise/internal/codeintel/autoindexing/transport/graphql/root_resolver.go
enterprise/internal/codeintel/shared/resolvers/index_resolvers.go
enterprise/internal/codeintel/shared/resolvers/index_step_resolver.go
enterprise/internal/codeintel/shared/resolvers/indexes_repository_namespace_resolver.go
enterprise/internal/codeintel/shared/resolvers/summary.go
enterprise/internal/codeintel/shared/resolvers/upload_resolver.go
enterprise/internal/codeintel/shared/resolvers/uploads_repository_namespace_resolver.go
enterprise/internal/codeintel/shared/types/indexer_resolver.go

@efritz efritz merged commit 91ea697 into main Mar 6, 2023
@efritz efritz deleted the ef/auto-indexing-updates branch March 6, 2023 22:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/graph Graph Team (previously Code Intel/Language Tools/Language Platform)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants