This repository was archived by the owner on Sep 30, 2024. It is now read-only.
client/web: Fix regression in connected accounts for ADO#48184
Merged
Conversation
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits aa32a80 and e5912f4 or learn more. Open explanation
|
sashaostrikov
approved these changes
Feb 24, 2023
sashaostrikov
left a comment
Contributor
There was a problem hiding this comment.
LGTM! left 1 question
| accountConnection = ( | ||
| <> | ||
| {account.external?.displayName} (@{account.external?.login}) | ||
| {account.external?.displayName ? ( |
Contributor
There was a problem hiding this comment.
question: can empty tags on lines 56 and 64 be removed?
Contributor
Author
There was a problem hiding this comment.
It's not an empty tag. It's wrapping the whole thing in an empty component without which the code does not compile.
Contributor
Author
There was a problem hiding this comment.
Maybe there's an elegant way to do this? I'm a tsx noob. :P
Contributor
There was a problem hiding this comment.
I know that this is an empty component, but it's still a tag :)
okay, I thought in this case it could have been omitted
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed this edge case when I was addressing code review comments in #47865.
Test plan
Before
After
App preview:
Check out the client app preview documentation to learn more.