Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

repos: exclude field for other#48168

Merged
keegancsmith merged 1 commit into
mainfrom
plz.review/review/19565
Feb 24, 2023
Merged

repos: exclude field for other#48168
keegancsmith merged 1 commit into
mainfrom
plz.review/review/19565

Conversation

@keegancsmith

@keegancsmith keegancsmith commented Feb 24, 2023

Copy link
Copy Markdown
Member

We add support for exclude names/patterns in the other external service following the same convention as in other external services. The motivation for this is when recursively adding repositories in App / Wizard we want a convenient way to exclude a repository.

Test Plan: added unit tests

Part of https://github.com/sourcegraph/sourcegraph/issues/47960

plz-review-url: https://plz.review/review/19565

@cla-bot cla-bot Bot added the cla-signed label Feb 24, 2023
@sourcegraph-bot

sourcegraph-bot commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff ad39257...da274ba.

Notify File(s)
@indradhanush internal/repos/other.go
internal/repos/other_test.go
@sashaostrikov internal/repos/other.go
internal/repos/other_test.go

@varsanojidan varsanojidan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@sashaostrikov sashaostrikov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from plz.review/review/19564 to main February 24, 2023 07:01
We add support for exclude names/patterns in the other external service
following the same convention as in other external services. The
motivation for this is when recursively adding repositories in App /
Wizard we want a convenient way to exclude a repository.

Test Plan: added unit tests

plz-review-url: https://plz.review/review/19565
@plz-review plz-review Bot force-pushed the plz.review/review/19565 branch from 263af8c to da274ba Compare February 24, 2023 07:01
@keegancsmith keegancsmith enabled auto-merge (squash) February 24, 2023 07:13
@keegancsmith keegancsmith merged commit 8e16a4b into main Feb 24, 2023
@keegancsmith keegancsmith deleted the plz.review/review/19565 branch February 24, 2023 07:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants