Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Fix various CodeMirror related issues in the side blob#48107

Merged
philipp-spiess merged 7 commits into
mainfrom
ps/various-codemirror-fixes
Feb 24, 2023
Merged

Fix various CodeMirror related issues in the side blob#48107
philipp-spiess merged 7 commits into
mainfrom
ps/various-codemirror-fixes

Conversation

@philipp-spiess

@philipp-spiess philipp-spiess commented Feb 23, 2023

Copy link
Copy Markdown
Contributor
  1. Fixes the issue where the syntax highlighting was sometimes showing invalid colors. This was caused by the inserted <a> tag to set a color.
  2. Greatly simplifies how we handle line numbers in the side blob which will now make it a very easy stupid link just like clicking on the content in the side blob

Paired on this with @taras-yemets

Test plan

Regarding 1:
Screenshot 2023-02-23 at 11 00 09

Regarding 2:

Screen.Recording.2023-02-23.at.11.32.09.mov

App preview:

Check out the client app preview documentation to learn more.

@philipp-spiess philipp-spiess self-assigned this Feb 23, 2023
@cla-bot cla-bot Bot added the cla-signed label Feb 23, 2023
@philipp-spiess philipp-spiess changed the title Fix various CodeMirror related issues Fix various CodeMirror related issues in the side blob Feb 23, 2023
@github-actions github-actions Bot added the team/code-exploration Issues owned by the Code Exploration team label Feb 23, 2023
Comment thread client/web/src/repo/blob/codemirror/linenumbers.ts Outdated
@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Feb 23, 2023

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (+0.07 kb) 0.00% (+0.24 kb) 0.00% (+0.17 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 68910a0 and 3b903e2 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

Comment thread client/web/src/repo/blob/codemirror/linenumbers.ts Outdated
Comment thread client/wildcard/src/global-styles/utilities/text.scss

@taras-yemets taras-yemets left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @philipp-spiess!

@sourcegraph-bot

sourcegraph-bot commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in OWNERS files for diff 08ae8d8...14ebbee.

Notify File(s)
@sourcegraph/code-exploration-devs client/wildcard/src/global-styles/utilities/text.scss
@vovakulikov client/wildcard/src/global-styles/utilities/text.scss

Comment thread client/web/src/repo/blob/codemirror/linenumbers.ts Outdated
@philipp-spiess philipp-spiess merged commit 719b2f5 into main Feb 24, 2023
@philipp-spiess philipp-spiess deleted the ps/various-codemirror-fixes branch February 24, 2023 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/code-exploration Issues owned by the Code Exploration team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants