This repository was archived by the owner on Sep 30, 2024. It is now read-only.
monitoring: vastly improved searcher dashboard#47654
Merged
Merged
Conversation
We introduce another graph which is the rate of traffic per response code. This is the first graph seen and gives a much better picture of what the service is doing and how well it is doing it. We keep the error percantage graph, but now it is the second row. The next commit will add another graph on that row to make it less big.
ca0116e to
0cffb93
Compare
Contributor
|
❌ Problem: the label |
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 260335c...0cffb93.
|
chwarwick
approved these changes
Feb 15, 2023
chwarwick
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me and I'll keep an eye on this dashboard as I run some insights.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating searcher metrics I noticed our dashboard for it pretty much has no information vs the wealth of metrics we record. As such I spiked an hour this morning adding dashboards to grafana. For context see these notes https://gist.github.com/keegancsmith/9e53a1df12b5b863249c59539c0410fd
I recommend just taking a look at the screenshots then briefly reviewing queries.
Before:
After:
Test Plan
Ran monitoring stack against production prometheus. Note: I wasted a lot of time trying to get this work on linux, but it seems a bunch of our stuff is broken there for local dev + grafana. So this only worked on my macbook.